-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support container interfaces for get() return type #39
Conversation
I see that the build is not passing, can you have a look at it please? |
The reported errors do not seem to be caused by the changes I made; some of them might even be temporary problems that might go away when re-running the checks (which I do not have the permissions to trigger I think). The codesniffer changes are probably caused by the fact that the rules were changed meanwhile. I'm pretty sure current master will fail the same. Not sure what your policy is who should fix those issues. In our libraries we use a composer.lock so dependencies (especially dev ones like codesniffer rules) cannot change without explicit action. I would assume that a PR like mine that is targeted at fixing a certain issue should only do that. So, how shall we proceed? |
Can you rebase this please? |
f2068fd
to
f76b6a5
Compare
Codecov ReportBase: 44.00% // Head: 43.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
============================================
- Coverage 44.00% 43.16% -0.84%
- Complexity 107 109 +2
============================================
Files 20 23 +3
Lines 275 278 +3
============================================
- Hits 121 120 -1
- Misses 154 158 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Rebased and "fixed" the coding standard issues. |
No description provided.